envoyproxy / envoyproxy/envoy-mobile

[Core] Potentially call other signal handlers when registering EM's own signal handling

Open
#2,033 1 comment 0 reactions 0 assignees View on GitHub
core help wanted no stalebot
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Envoy Mobile (and Envoy) register signal handlers to gracefully execute shutdown when a process is to be terminated. In the case of Envoy Mobile, this is needed to help avoid certain crashes that can occur due to orphaned/inconsistent state that can arise depending on the other in which threads are terminated.

However, today the handlers are registered irrespective of other handlers that may have been previously registered. As a library, Envoy Mobile should respect and call a previously registered handler as part of the process of running its own handlers via the return value of `sigaction`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.