envoyproxy / envoyproxy/envoy-mobile

Streamline event tracker registration

Open
#1,676 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

There's some room for improvements in the event tracking registration and consumption part of the code.

Here's the improvements to make:

1) Add a `isRegistered(std::string name)` method to [external.h](https://github.com/envoyproxy/envoy-mobile/blob/main/library/common/api/external.h)
2) Ping one of the maintainers to merge https://github.com/envoyproxy/envoy-mobile/pull/1673
3) Map the change in step 2 for iOS in [EnvoyEngineImpl.m](https://github.com/envoyproxy/envoy-mobile/blob/main/library/objective-c/EnvoyEngineImpl.m#L453-L461) - do not call `register_platform_api` when `ios_track_event` is null

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.