envoyproxy / envoyproxy/envoy-mobile

EnvoyHTTPCallbacks.onData() systematically gets called with an empty chunk

Open
#1,393 0 comments 0 reactions 0 assignees View on GitHub
cronet no stalebot
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

it looks like that the EnvoyHTTPCallbacks.onData() systematically gets called with an empty chunk (ByteBuffer.remaining() == 0 and endStream == true). When the Content-Length is provided in the response header, would it be advisable to rather have the callback to provide the last chunk with data? (ByteBuffer.remaining() != 0 and endStream == true). Note: for the Cronvoy implementation, this does not really matter: the last callback can be ignored when the Content-Length is provided.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.