envoyproxy / envoyproxy/envoy-mobile

stats: use internal context to support StatsClient stats

Open
#1,034 2 comments 0 reactions 0 assignees View on GitHub
no stalebot observability/stats
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Moving to an internal context would allow us to avoid contention and reduce memory usage whenever we record stats. One such example may be found here:
https://github.com/envoyproxy/envoy/blob/master/source/common/http/user_agent.h

Note that the context itself would need to be guarded by a mutex, but stats artifacts it produced could theoretically then be used safely from any thread, avoiding needless dispatch.

Thank you to @jmarantz for graciously sharing his thoughts and insight on this topic.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.