enthought / enthought/traitsui

Make sure all trait listeners get unhooked

Open
#1,526 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
306
Forks
99
PR merge metrics
No merged PRs in 30d

Description

There are some cases where we set up trait listeners but never ultimately unhook them (i.e. we never call `.observe(..., remove=True))`. In many of these cases the use of the code is transient (e.g. examples / tests), but in any case it is best to always be safe. Any code which isn't transient this is very important as it could lead to strange bugs.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for trait listener setup and calls to .observe(..., remove=True), including examples and tests, then identify listeners that can outlive their intended use. Done means every listener established by the affected code has a corresponding unhook path, including transient usage where practical.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.