enthought / enthought/traitsui

Consider removing connection type setting for QPushButton

Open
#1,308 0 comments 0 reactions 0 assignees View on GitHub
toolkit: Qt type: cleanup
Dominant language
Python
Stars
306
Forks
99
PR merge metrics
No merged PRs in 30d

Description

https://github.com/enthought/traitsui/pull/1303 sets the QPushButton click slot connection type to QueuedConnection in order to address missing/weird repainting issue on Qt 5 and OSX when a QPushButton is pressed.

The behaviour has been observed on OSX 10.15.5 and PySide2 5.15 and PyQt 5.14.

The closest unresolved bug I can find on Qt bug tracker is this: https://bugreports.qt.io/browse/QTBUG-68067

Once the issue is resolved upstream, we should consider removing the type setting and revert back to using the default auto connection.

So far I don't think it hurts to setting the connection type to queued connection actually. The only cost is that test code will need to be more diligent about forcing GUI events to be processed, but that would be good practice for test code anyway. I think we prefer using the default if it is good enough.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.