enthought / enthought/traitsui

TreeEditor shouldn't modify old_value in update_editor

Open
#1,236 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
306
Forks
99
PR merge metrics
No merged PRs in 30d

Description

The `old_value` attribute is supposed to hold the original value of the trait:

https://github.com/enthought/traitsui/blob/872cc7398b26773ace423a266b71cecfa28b3566/traitsui/editor.py#L84-L86

However, `SimpleEditor` tries to modify it in `update_editor`:

https://github.com/enthought/traitsui/blob/872cc7398b26773ace423a266b71cecfa28b3566/traitsui/qt4/tree_editor.py#L266-L284

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.