enthought / enthought/traits

Revisit pickling logic for TraitListObject

Open
#996 0 comments 0 reactions 0 assignees View on GitHub
type: refactor
Dominant language
Python
Stars
462
Forks
90
PR merge metrics
No merged PRs in 30d

Description

This is a reminder to myself to revisit the pickling infrastructure for `TraitListObject` at some point before the 6.1.0 release. In particular:

- we don't have good tests for pickling and unpickling; there are some indirect tests, but it would be good to have direct unit tests in `test_trait_list_object`
- with the right unpickling setup, it shouldn't be necessary to verify that `self.trait` exists when validating the length
- I'd like to understand better the need for the `object` and `trait` manipulations in `__getstate__` and `__setstate__`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.