enthought / enthought/traits

Remove `trait_modified`

Open
#1,097 2 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
Python
Stars
462
Forks
90
PR merge metrics
No merged PRs in 30d

Description

Every `HasTraits` subclass comes with a `trait_modified` Event trait. However, this trait is never fired by anything in ETS, and is never observed by any ETS-using project code available to me.

Nevertheless, removing this could break existing code that grabs the `traits` dictionary from an object and then explicitly deletes the `"trait_added"` and `"trait_modified"` names because they're not interesting. Such code definitely exists. The fix for that code should be trivial, but it'll still need fixing.

So I think we can't actually _remove_ this until 7.0.0. I can't think of a way to noisily deprecate it in the code before then, but we could advertise the planned removal in a prior release (6.1 or 6.2).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.