enthought / enthought/traits

TraitList, TraitDict, TraitSet don't catch notification errors

Open
#1,057 8 comments 0 reactions 0 assignees View on GitHub
type: discussion
Dominant language
Python
Stars
462
Forks
90
PR merge metrics
No merged PRs in 30d

Description

Currently all three of the new container classes dispatch notification via a simple:
```
for notifier in self.notifiers:
notifier(self, index, removed, added)
```
This means that if a single notifier fails, all subsequent notifiers will not be called. This is different from the behaviour of standard Trait notification.

Trait container notifiers should have similar behaviour to trait notifiers, and if we do not fix this may lead to subtle bugs in the new observer framework where an unrelated error in a notification may mean that observers are not hooked and unhooked correctly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.