enthought / enthought/traits

Fix default validator tests for TraitSet, TraitList and TraitDict

Open
#1,042 0 comments 0 reactions 0 assignees View on GitHub
component: test suite type: cleanup
Dominant language
Python
Stars
462
Forks
90
PR merge metrics
No merged PRs in 30d

Description

This came up in https://github.com/enthought/traits/pull/1040#discussion_r415916867

Currently the initialization tests simply check that the validator is set to the right function (`_validate_everything`), but the fact that it is this specific function is an implementation detail and should not be actively tested. The behaviour of the validator should be tested instead and references to `_validate_everything` function should be removed from these tests.

See linked discussion for more detailed explanation.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.