enthought / enthought/pyface

Toolkit specific code in seemingly agnostic modules.

Open
#957 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
115
Forks
54
PR merge metrics
No merged PRs in 30d

Description

This was motivated by https://github.com/enthought/pyface/pull/954#discussion_r654393738

Basically, the module `pyface/dock/dock_sizer.py`, given that there is no wx along its path, appears like it would be toolkit agnostic.
Similarly in `pyface/sizers/`. However, these modules directly do `import wx`.

We should audit the codebase for such occurrences. I believe in an idea world we would have these modules have a `___ = toolkit_object("_____")` and then some separate module eg `pyface/ui/wx/dock/dock_sizer.py` containing the wx specific code. (I would think this is true even if there is no qt analogue for these sorts of things, but perhaps

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.