enthought / enthought/pyface

UndoAction and RedoAction should enable/disable when unavailable

Open
#875 0 comments 0 reactions 0 assignees View on GitHub
difficulty: intermediate type: enhancement
Dominant language
Python
Stars
115
Forks
54
PR merge metrics
No merged PRs in 30d

Description

Currently `UndoAction` and `RedoAction` are always enabled. However, if there is nothing to undo or redo, standard OS behaviour is to disable the actions.

This may require some changes to the `IUndoManager` and `ICommandStack`, as the current interface has no direct, reliable signal that the `undo` or `redo` methods do anything - currently they use the `undo_name` and `redo_name` as signals, but this requires all `Command` objects to have a non-empty name, which seems fragile.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.