enthought / enthought/pyface

Remove added compatibility layer for QFontMetrics.width deprecation warnings when we drop support for old versions of pyqt5

Open
#717 0 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
Python
Stars
115
Forks
54
PR merge metrics
No merged PRs in 30d

Description

In #715 we added a compatibility layer to avoid a deprecation warning when calling `QFontMetrics.width()`. Namely we added variations of the following code
```
if QtCore.__version_info__ >= (5, 11):
_____ = QFontMetrics.horizontalAdvance(_____)
else:
_____ = QFontMetrics.width(_____)
```

Once we drop support for older versions of PyQt5, this logic can be removed and we can simply call `.horizontalAdvance()`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.