enthought / enthought/pyface

Incomplete interface implementations

Open
#551 1 comment 0 reactions 0 assignees View on GitHub
difficulty: intermediate
Dominant language
Python
Stars
115
Forks
54
PR merge metrics
No merged PRs in 30d

Description

- [ ] `MSplashScreen.close` doesn't pass `force` kwarg defined on `IWindow.close`
- [ ] `MWindow` is missing `IWindow.key_pressed`
- [ ] `pyface.tests.test_new_toolkit.widget.Widget` doesn't fully implement the `IWidget` interface.
- [ ] `MEventTimer` doesn't fully implement the `ITimer` interface. It's missing a number of traits.
- [ ] `MCallbackTimer` doesn't fully implement the `ITimer` interface. It's missing a number of traits.
- [ ] null-backend `Widget` is missing the `show` method to fully implement `IWidget` interface.
- [ ] qt4 and wx-backend `DirectoryDialog.close` doesn't fully implement the `IWindow.close` interface - it's missing a `force` kwarg
- [ ] qt4 and wx-backend `Field` is missing the `show_context_menu` method to fully implement the `IField` interface.
- [ ] qt4 and wx-backend `FileDialog.close` doesn't fully implement `IWindow.close`. It's missing the `force` kwarg
- [ ] qt4-backend `HeadingText` is missing an `image` trait to fully implement the `IHeadingText` interface.
- [ ] qt4-backend `ProgressDialog` doesn't fully implement the `IDialog` interface - it is missing a number of traits and it doesn't fully implement `IWindow.close` as it's missing a `force` kwarg.
- [ ] qt4-backend `PythonEditor` is missing `set_style` to fully implement the `IPythonEditor`.
- [ ] qt4 and wx-backend `SingleChoiceDialog.close` is missing the `force` kwarg to fully implement `IWindow`
- [ ] qt4-backend `Window` is missing `key_pressed` to fully implement `IWindow`

See PR https://github.com/enthought/pyface/pull/554 which fixes all of these interface issues which seems to be causing test failures.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.