enthought / enthought/pyface

PyfaceColor traits should have an allow_none option

Open
#547 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
115
Forks
54
PR merge metrics
No merged PRs in 30d

Description

This has not been merged yet, but rather than adding to the PR, it probably makes sense to add options to have these traits hold a `None` value as with `Instance` traits. The default should be `False`. When `allow_none` is `True`, if no other default is supplied it should be `None`, as with an instance trait.

This makes it easier for a class to say they have no preference about a color choice.

There may be a reasonable argument to also do this for `PyfaceFont` trait type as well.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.