Buttons are not set up correctly in ui/qt4/progress_dialog.py
Open
Good First Issue
- Dominant language
- Python
- Stars
- 115
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
Issue: when clicked, "Cancel" button closes dialog window but does not return `self._user_cancelled = True` during update or calls `reject` function.
Possible solution: replace lines 147, 148:
``` python
if self.can_cancel:
buttons.connect(buttons, QtCore.SIGNAL('rejected()'), dialog, QtCore.SLOT('reject()'))
```
with
``` python
if self.can_cancel:
buttons.clicked.connect(self.reject)
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.