enthought / enthought/mayavi

Scene related actions use "window" which is not part of class definitition

Open
#997 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.4k
Forks
316
Avg merge
7h 44m
Merged PRs (30d)
5

Description

The `Action` classes defined here: https://github.com/enthought/mayavi/blob/master/tvtk/plugins/scene/ui/actions.py
have methods that reference `self.window`, but the classes do not explicitly have a `window` trait/attribute.

When they are instantiated, they are given a window, e.g.:
https://github.com/enthought/mayavi/blob/61ef7c0eebbdca474b7cfdf6082bfc17fb5aaf59/mayavi/plugins/envisage_engine.py#L85

It would be easier to understand if `window` was explicitly part of the class definition

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.