enthought / enthought/envisage
Improve tests for AbstractActionManagerBuilder.create_tool_bar_managers
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 89
- Forks
- 27
- Avg merge
- 14h 48m
- Merged PRs (30d)
- 7
Description
There's currently an undefined name in the AbstractActionManagerBuilder.create_tool_bar_managers function: https://github.com/enthought/envisage/blob/4674dd44d8989ffb99b4efa339745cac3f702c0b/envisage/ui/action/abstract_action_manager_builder.py#L71
That action should clearly be group, and that's fixed in #270, but the fact that it went undetected means that we're not testing that code path. We should fix that.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in envisage/ui/action/abstract_action_manager_builder.py at AbstractActionManagerBuilder.create_tool_bar_managers and locate the existing tests for this builder. Add coverage for the untested code path so an undefined name like the reported action/group mistake is detected; the relevant test suite should pass when the regression is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100