enthought / enthought/enable

Font class validation has issues

Open
#933 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
97
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Two issues with `Font` class validation:
- When given invalid values, the `Font` class raises `RuntimeError`. `ValueError` likely makes more sense.
- the validation only checks types, but many of the values have additional restrictions (eg. font size needs to be positive, some values are effectively enums, etc.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.