enthought / enthought/apptools

PreferencesHelper with Enum trait containing Python keywords or builtins leads to errors

Open
#301 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
38
Forks
21
PR merge metrics
No merged PRs in 30d

Description

I stumbled upon this when defining a preferences helper for a logging configuration.
When defining an Enum trait whose values contain strings that map to Python keywords or builtins (like the logging level "Warning"):
![image](https://user-images.githubusercontent.com/48917891/139426969-65a4a809-b5a6-47f3-aa57-2b24e6858f14.png)
Upon initialization of the preferences, the _get_value method of the PreferencesHelper class, will call an eval on "Warning", which results in a type instance of Warning. The following Enum trait validator then fails since the Warning type in not contained in the enum.
![image](https://user-images.githubusercontent.com/48917891/139427401-458fc15e-0a81-4c88-a7b8-d0f2ad731268.png)

When specifying the default preferences like this:
```
[application_logger]
default_level = "Warning"
```
works upon loading the first app startup.
But after closing the application, the user preferences are re-written, resulting in "Warning" being dumped without ticks.

A potential solution might be executing the "eval" and then dismissing results that are builtins?

Using apptools 5.1.0, traits 6.3.1, Win10

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.