enjalot / enjalot/blockbuilder

Error line numbers off-by-1 for <script> tags

Open
#142 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
332
Forks
59
PR merge metrics
No merged PRs in 30d

Description

Thanks for the awesome work on Blockbuilder! I'm loving the error notification, but it seems to be off by one if the error occurs inside a `` tag. For example, in the below screenshot, the error should be on the line that imports `d3.geo.tile.min.js`.

![image](https://cloud.githubusercontent.com/assets/68416/16169283/c8c0bf2c-3545-11e6-9691-893a44e70536.png)

Here's an [example you can use to reproduce the issue](http://blockbuilder.org/curran/5a415caef559cb84acb542f3af39e51e).

When I first encountered the error, my screen looked like this:

![image](https://cloud.githubusercontent.com/assets/68416/16169300/4cec0fb8-3546-11e6-928b-71825cff2800.png)

and I spent some time barking up the wrong tree, thinking the error was from the topojson script.

All the best!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.