endolith / endolith/waveform-analysis
Analyze channels function is ugly
- Dominant language
- Python
- Stars
- 287
- Forks
- 83
- Avg merge
- 16m
- Merged PRs (30d)
- 2
Description
I've got common.py with `load()` and `analyze_channels()`, but then wave_analyzer.analyze() does the same thing.
I want everything wrapped in `try:` so it can run without any command line window and just pop up the results using easygui, or Exceptions in easygui if they happen, but then everything is wrapped in a `try` statement which is ugly. Separate file that launches the rest?
Having each analysis in its own function is nice, but if multiple functions are doing the same FFT on the same signal, wouldn't it be better to keep the previously-computed FFT to save time? So I should pass an object to the analysis functions instead, and if they compute FFT they should attach FFT results to the object as a cache?
Then I've still got the standalone gists for each analysis function that should be merged into this and killed off.
Suggestions welcome
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.