encima / encima/jsc3d

Cannot load URLs with special characters

Open
#121 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
HTML
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
What steps will reproduce the problem?
1. Use a SceneUrl URL like "http://example.com/foo%20bar.stl"

What is the expected output? What do you see instead?
- Even though the URL is properly-encoded, it fails to load the file.
- On the network, it shows that it actually tried to open
"http://example.com/foo%2520bar.stl"

What version of the product are you using? On what operating system?
- Latest SVN Checkout
- Google Chrome Canary 40

Please provide any additional information below.

This happens because it calls `encodeURI` on the URL even though it is already
properly encoded. To prevent double-encodings, `encodeURI` should not be called
here but by the implementor that uses the links if he thinks his URLs are not
properly encoded already.

The attached patch removes calls to `encodeURI` and fixes the problem.
```

Original issue reported on code.google.com by `negatif@gmail.com` on 13 Oct 2014 at 12:17

Attachments:
- [noEncodeUri.patch](https://storage.googleapis.com/google-code-attachments/jsc3d/issue-121/comment-0/noEncodeUri.patch)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the encodeURI calls involved in loading SceneUrl links and reproduce the issue with a URL containing %20, such as http://example.com/foo%20bar.stl. Done means the already-encoded URL is requested unchanged rather than being double-encoded; the attached noEncodeUri.patch provides additional context.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.