emscripten-core / emscripten-core/emsdk
Can we simplify the windows building by always using `-G Ninja`?
- Dominant language
- Python
- Stars
- 3.7k
- Forks
- 821
- Avg merge
- 1h 25m
- Merged PRs (30d)
- 3
Description
If we always using ninja we can simplify the windows build and remove all the handling of different MSVC versions?
We could just mandate that if you want to build anything form source you need to run emsdk from visual sudio command prompt. (i.e. you are expected to have run vsvarsall.bat already and/or have cl.exe in PATH).
@juj do you have any reason not to use ninja for all your windows builds?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by tracing the Windows build path in emsdk and locating the existing handling for different MSVC versions and generators. Check how the Visual Studio environment is detected or required, then verify that Windows builds consistently use the Ninja generator and document the expected cl.exe or vsvarsall.bat prerequisite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100