emscripten-core / emscripten-core/emsdk

Re-use the emsdk build rules in emscripten-releases?

Open
#1,732 3 comments 0 reactions 1 assignee Claimed by @dschuff View on GitHub
Dominant language
Python
Stars
3.7k
Forks
821
Avg merge
1h 25m
Merged PRs (30d)
3

Description

Currently emscripten-releases essentially duplicates the emsdk build rules for binaryen and llvm (and emscripten itself).

This means that the emsdk build rules can bitrot (at least until @juj comes along and fixes them).

Instead, I propose that we add emsdk to the DEPS (essentially a submodule) of emscirpten-releases, and delete all the duplicated logic from emscripten-releases build.py.

I bet an AI agent could quickly identify any divergences and fix them (any such divergences already represent real issues that are probably worth fixing regardless).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.