emscripten-core / emscripten-core/emscripten

EMSCRIPTEN_FETCH_REPLACE needed for loads to memory?

Open
#8,183 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

The testcase here:

https://github.com/emscripten-core/emscripten/compare/fetch-wasm-pthread-async?expand=1

passes as is, but if `EMSCRIPTEN_FETCH_REPLACE` is removed then it fails. That seems odd since the docs say

> // If the file already exists in IndexedDB, the old file will be deleted and a new download is started.

But the test does not do anything with IndexedDB, it just fetches to memory. Are the docs out of date, or does REPLACE mean something here?

cc @juj

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.