emscripten-core / emscripten-core/emscripten

Get WebRTC backend working again

Open
#3,818 12 comments 0 reactions 0 assignees View on GitHub
filesystem help wanted networking tests
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Poking at the test `sockets.test_webrtc`, I see that we have removed the whole WebRTC backend from Emscripten altogether. WebRTC used to be implemented in `src/library.js`, see e.g. at this point of time: https://github.com/kripken/emscripten/blob/3b99bb7bef220ad98760b117d14854098f86db9e/src/library.js#L7032, where the two implementations WebRTC vs WebSockets were chosen based on a `#if SOCKET_WEBRTC`. Looks like the WebRTC part of it was never integrated as part of the filesystem in `src/library_sockfs.js`, which only carries WebSockets -specific code.

This commit https://github.com/kripken/emscripten/commit/d92efe09c6bc825539f9ce8f7e10ac2fcde0bdaf removes the sockets specific code from `src/library.js`, but looks like the WebRTC implementation was not migrated anywhere else, so it got lost as part of the refactoring.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.