emscripten-core / emscripten-core/emscripten

Using #warning in JS library files diagnoses three times.

Open
#26,577 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

`liba.js`
```js
#warning This is a test.
```

results in

```
$ emcc test/hello_world.c --js-library liba.js -o a.js

warning: liba.js:1: #warning This is a test.
warning: liba.js:1: #warning This is a test.
emcc: warning: warnings in JS library compilation [-Wjs-compiler]
```

First line is duplicated.

Is there value in the third line to be separate?

E.g. could this be

```
$ emcc test/hello_world.c --js-library liba.js -o a.js

warning: liba.js:1: #warning This is a test. [-Wjs-compiler]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.