emscripten-core / emscripten-core/emscripten

libsdl.js and self-compiled SDL2 confusion

Open
#26,271 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Emscripten v. `3.1.46`, but also present in main.

It's more like a question then a bugreport, but please help me understand this.
If I build my own SDL2 library for Emscripten and provide -sUSE_SDL=0 (which is the default anyway), why old SDL1 `libsdl.js` is pulled by default? https://github.com/emscripten-core/emscripten/blob/efa28970cf4e1a3a3080e898bdc5d5df163e0705/src/modules.mjs#L146-L148

It is not needed for -sUSE_SDL2 based on this line https://github.com/emscripten-core/emscripten/blob/efa28970cf4e1a3a3080e898bdc5d5df163e0705/src/modules.mjs#L156-L158

Is it a bug or is it intentional?

Thanks.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.