emscripten-core / emscripten-core/emscripten

MainLoop object updateStatus() method error

Open
#26,076 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

At emcc built js file:
The MainLoop object updateStatus() method:
``` js
updateStatus() {
if (Module['setStatus']) {
var message = Module['statusMessage'] || 'Please wait...';
var remaining = MainLoop.remainingBlockers ?? 0;
var expected = MainLoop.expectedBlockers ?? 0;
if (remaining) {
if (remaining < expected) {
Module['setStatus'](`{message} ({expected - remaining}/{expected})`);
} else {
Module['setStatus'](message);
}
} else {
Module['setStatus']('');
}
}
}
```
the line:
``` js
Module['setStatus'](`{message} ({expected - remaining}/{expected})`);
```
should be
``` js
Module['setStatus'](`${message} (${expected - remaining}/${expected})`);
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.