emscripten-core / emscripten-core/emscripten

[macos] Emscripten other tests hanging when run with node 18-19 on Chromium CI

Open
#22,022 0 comments 0 reactions 0 assignees View on GitHub
macOS
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

When we tried to update Chromium CI's version of node to v18.20.3, (https://chromium-review.googlesource.com/c/emscripten-releases/+/5503423/2, patchset 2) we found a strange case where the [tests](https://ci.chromium.org/ui/p/emscripten-releases/builders/try/mac/b8747138675083896161/overview) on the mac builder hung without any useful output.
I subsequently tried node v19, 20, and 22 (patchsets 6, 8, and 7 respectively. Node 19 displayed the [same](https://ci.chromium.org/ui/p/emscripten-releases/builders/try/mac/b8746591123531170129/overview) behavior, while the tests for [20](https://ci.chromium.org/ui/p/emscripten-releases/builders/try/mac/b8746494096135673233/overview) and [22](https://ci.chromium.org/ui/p/emscripten-releases/builders/try/mac/b8746559240969384369/overview) did not.

The current plan is just to revert https://github.com/emscripten-core/emscripten/pull/22010 for now, which would mean we'd still be distributing node 18 in emsdk, but default emscripten output wouldn't refuse to run on node 16. That seems fine until we figure out what's happening with node 18 or decide to just use a different node on chromium CI

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.