emscripten-core / emscripten-core/emscripten

In `-sMODULARIZE` mode the `moduleArg` should not be modified in place

Open
#21,648 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Right now you can observe the new module object propertires before the module promise resolves, breaking the encapsulation.

I tried to avoid this in the past but its make very hard due the way fact that we `return moduleArg` at the end of the generated code and returning anything else is tricky when building with `--closure=1`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.