emscripten-core / emscripten-core/emscripten
webidl_binder.py contains unguarded asserts
- Dominant language
- C++
- Stars
- 27.6k
- Forks
- 3.6k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 105
Description
As of Emscripten 3.1.48:
> The JS `assert` function is no longer available in release builds when `-sSTRICT` is used. This should only affect users with custom JS library code which doesn't use `#if ASSERTIONS` guards around their `assert` calls.
webidl_binder.py contains several `assert`s which aren't guarded. Incomplete list:
https://github.com/emscripten-core/emscripten/blob/ce5114bdd2175c7297583d3c25a53ca95d22f4ce/tools/webidl_binder.py#L217
https://github.com/emscripten-core/emscripten/blob/ce5114bdd2175c7297583d3c25a53ca95d22f4ce/tools/webidl_binder.py#L222
https://github.com/emscripten-core/emscripten/blob/ce5114bdd2175c7297583d3c25a53ca95d22f4ce/tools/webidl_binder.py#L229
Contributor guide
Assessment
This issue has not been assessed yet.