emscripten-core / emscripten-core/emscripten
Enable ABORTING_MALLOC by default when ALLOW_MEMORY_GROWTH is set?
Open
- Dominant language
- C++
- Stars
- 27.6k
- Forks
- 3.6k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 105
Description
Currently it looks like ABORTING_MALLOC defaults to
- ON if building with memory growth disabled, and to
- OFF, when building with allow memory growth enabled.
This difference seems arbitrary. Having aborting malloc is orthogonal to whether memory growth is enabled, so it would be best to have aborting malloc always enabled by default to be consistent? Naturally in ALLOW_MEMORY_GROWTH+ABORTING_MALLOC builds, one should only abort after resizing the wasm heap fails. (like it already does happen)
Contributor guide
Assessment
This issue has not been assessed yet.