emscripten-core / emscripten-core/emscripten

importing shared.py has many side effect, but really shouldn't

Open
#19,490 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Importing this module sets up a bunch of stuff and checks a bunch of stuff here. We should really not be doing that at impot time.

See the TODO here: https://github.com/emscripten-core/emscripten/blob/6de3b76b7ebbb641e1e06bd0bf45b12b9d4615b1/tools/shared.py#L747-L749

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.