emscripten-core / emscripten-core/emscripten

embind code contains unguarded calls to `assert` which doesn't work with MINIMAL_RUNTIME

Open
#19,453 0 comments 0 reactions 0 assignees View on GitHub
embind
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

This is not effect the normal runtime since `assert` is always defined, but with `MINIMAL_RUNTIME` this is only conditionally defined... which mean embind + MINIMAL_RUNTIME doesn't currently work without ASSERTIONS enabled.

Is embind supposed to work with MINIMAL_RUNTIME? Perhaps we just need to disallow this combination.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.