emscripten-core / emscripten-core/emscripten

Non null terminated strings in em_asm section

Open
#19,197 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

It appeared that `get_section_strings` in `extract_metadata.py` can't handle strings that don't end with \00.

The story is following. We have our own language in which strings are not null terminated and store their length instead. So we have met some problems when upgrading to a newer version of emscripten.

There was a fix written that we use locally. And i would like to ask if it is possible to merge that fix and, if yes, how to do it better.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.