emscripten-core / emscripten-core/emscripten

[@types/emscripten]: `preRun`missing arg

Open
#18,789 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Currently the type signature of `preRun` is `(() => void)[]`. Instead it should be more like

```ts
type singlePreRunType = ((arg: SWIPLModule) => void) | (() => void);
type preRunType = singlePreRunType | singlePreRunType[] | undefined;
```

as can be seen in the usage in https://github.com/eyereasoner/eye-js/pull/79/files

Also reported in https://github.com/rla/npm-swipl-wasm/issues/13

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.