emscripten-core / emscripten-core/emscripten

EXPORT NAME isidentifier() check prevents exporting into, e.g. AudioWorkletGlobalScope

Open
#17,319 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Forgive me if I can fix this easily in my code, but since a fairly recent emscripten version, I have problems exporting a wasm module which needs to be in the AudioWorkletGlobalScope. It seems like it is a valid js indentifier, e.g. **AudioWorkletGlobalScope.WAM.MyWebAudioModule**, but the emcc python script doesn't allow it. If I comment out this check it builds and works fine.

https://github.com/emscripten-core/emscripten/blob/4b5c4f0694174e081661944ab3ffdb43dd1949b8/emcc.py#L2572

What would be the best solution?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.