emscripten-core / emscripten-core/emscripten

Allow pre-shifted indices in makeGetValue? Or some new helper

Open
#17,310 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

When working on changes such as #17293 it was noticed that moving from explicit HEAP access to makeGetValue/makeSetValue we lost the ability to hoist the initial `>>2` or `>>3` outside of a loop.

Perhaps we can add a new `preShifted=true` argument or we could create a completely new helper function.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.