emscripten-core / emscripten-core/emscripten

WasmFS: Take canRead and canWrite parameters into account when setting directory mode

Open
#17,125 0 comments 0 reactions 0 assignees View on GitHub
wasmfs
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 6h
Merged PRs (30d)
109

Description

Preloaded directories are always marked readable but not-writable:

https://github.com/emscripten-core/emscripten/blob/531257621816c200bc7c3be53129494afd029aec/system/lib/wasmfs/wasmfs.cpp#L140

But the call to createPath includes argument canWrite which can be true:

https://github.com/emscripten-core/emscripten/blob/531257621816c200bc7c3be53129494afd029aec/src/library_wasmfs.js#L65-L68

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.