emscripten-core / emscripten-core/emscripten

Misinformation in the FS.init() docs

Open
#17,117 3 comments 1 reaction 0 assignees View on GitHub
docs
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

The FS.init() docs at:

say that the input proxy function "should return an ASCII character code..." and that the output proxies "will be called with an ASCII character code whenever the program writes..."

That cannot possibly be correct: ASCII is limited to the range 0-127, inclusive, and emscripten-compiled binaries have no problems outputting non-ASCII UTF-8 characters (e.g. emoji), all of which have bit 8 set (and are thus greater than 127).

_Presumably_ the intent of those docs is that the functions must return an integer in the range 0..255, inclusive?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.