emscripten-core / emscripten-core/emscripten

Remove SHELL_FILE setting?

Open
#16,588 7 comments 0 reactions 1 assignee Claimed by @sbc100 View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

This setting is completely untested, and it looks like it allows the user to override the JS shell file from the default of `src/shell.js` or `src/shell_minimal.js`.

These shell files used be split into two sections with `{{BODY}}` in the middle but it looks like this feature isn't needed either since both our shell files end when with `{{BODY}}` with no further content.

If we do have users of `-sSHELL_FILE` out there they would have to constantly work to keep their shell.js ABI in sync with all changes to emscripten, so it seems unlikely there are any.

Should I add a warning if they settings is used, and then remove it completely in a few releases?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.