emscripten-core / emscripten-core/emscripten

Can we suppress closure warnings regarding assigning boolean to TypedArrayBufffer?

Open
#16,311 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

We are having to do some fairly nasty hacks right now to avoid the closure warnings: #16308

We could add more code to covert to an number. i.e. `? 1 : 0`. But that seems kind of pointless given that its the default cooersion.

Perhaps we could override the `TypedArrayBufffer.prototype.set` to accept `{number|boolean}` ? Perhaps closure would accept this change upstream?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.