emscripten-core / emscripten-core/emscripten

Enable function names by default in all test suites?

Open
#15,470 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

Its pretty unhelpful to see reports from builders that look like this one: https://github.com/emscripten-core/emscripten/issues/15468

```
RuntimeError: Aborted(RuntimeError: Aborted(Assertion failed: undefined))
at abort (C:\b\s\w\ir\tmp\t\tmp3j_wc7cp\emscripten_test_other_86z_eylk\a.out.js:1515:11)
at ___syscall_readlink (C:\b\s\w\ir\tmp\t\tmp3j_wc7cp\emscripten_test_other_86z_eylk\a.out.js:4471:69)
at :wasm-function[41]:0xf7a
at :wasm-function[12]:0x774
at main (:wasm-function[10]:0x3d7)
at C:\b\s\w\ir\tmp\t\tmp3j_wc7cp\emscripten_test_other_86z_eylk\a.out.js:1559:22
at callMain (C:\b\s\w\ir\tmp\t\tmp3j_wc7cp\emscripten_test_other_86z_eylk\a.out.js:5099:15)
```

Having the names of the intervening functions would make diagnostics much faster.

I believe the cheapest way to do this is to run all tests with `--profiling-functions` by default. (some tests may want to opt out of course).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.