emscripten-core / emscripten-core/emscripten
tests/test_benchmark.py run_binaryen_opts() composes an impossible path
Open
- Dominant language
- C++
- Stars
- 27.6k
- Forks
- 3.6k
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 105
Description
file `tests/test_benchmark.py` contains this:
```python
os.path.join(building.get_binaryen_bin(), 'wasm-opt', '--all-features')
```
I am not strong with python and did not actually execute the code, but it seems to produce an impossible path `/usr/bin/wasm-opt/--all-features`.
The option should be outside the parense, like this:
```python
os.path.join(building.get_binaryen_bin(), 'wasm-opt'), '--all-features'
```
Perhaps noone has used that script with binaryen_opts set?
Contributor guide
Assessment
This issue has not been assessed yet.