emscripten-core / emscripten-core/emscripten

Use console.log to print values of args of emscripten_set_canvas_element_size

Open
#14,551 3 comments 1 reaction 0 assignees View on GitHub
good first bug help wanted
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

the type of log message is not considered an error. It is small but makes us confusing as see the console. We might think that an error returned as calling emscripten_set_canvas_element_size. Should be changed to log or info.

https://github.com/emscripten-core/emscripten/blob/9dd9c35fdddc19b9a843cd9406657fc37e16dc45/src/library_html5.js#L2494

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.