emscripten-core / emscripten-core/emscripten

WebIDL Binder binder generates incorrect JS code when IDL_CHECKS="ALL"

Open
#13,897 1 comment 0 reactions 0 assignees View on GitHub
wontfix
Dominant language
C++
Stars
27.6k
Forks
3.6k
Avg merge
1d 1h
Merged PRs (30d)
105

Description

If I set `IDL_CHECKS="ALL"` instead of `IDL_CHECKS="DEFAULT"` when calling `webidl_binder.py`, generated code doesn't use `.ptr` when passing references/pointers in some cases (e.g. when overloading methods with parameters of type `double`)

Example IDL:
Captura de pantalla 2021-04-15 a las 0 42 22
Incorrect `ClassB::f()`:
Captura de pantalla 2021-04-15 a las 0 43 53
Correct `ClassC::f()`:
Captura de pantalla 2021-04-15 a las 0 45 05

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.