emqx / emqx/flowsdk

This error condition should use ParseError::BufferTooShort instead of ParseError::More. The ParseError::More variant expects different parameters and semantics for incomplete data scenarios.

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
21
Forks
6
Avg merge
3h 5m
Merged PRs (30d)
1

Description

This error condition should use ParseError::BufferTooShort instead of ParseError::More. The ParseError::More variant expects different parameters and semantics for incomplete data scenarios.
```suggestion
return Err(ParseError::BufferTooShort(
vsn_offset + 1 - self.buffer.len(),
));
}
}
```

_Originally posted by @Copilot in https://github.com/emqx/flowsdk/pull/26#discussion_r2369161932_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.